[A2-P] 李畅松 - 提交 profiling 实验结果 - #157
Open
maybe1possible wants to merge 3 commits into
Open
Conversation
WillQvQ
requested changes
Aug 8, 2026
WillQvQ
left a comment
Contributor
There was a problem hiding this comment.
审核结论:需要修改后再合并。
当前有以下阻塞:
- PR 越界新增
docs/li-changsong-a2-gpu-manual.md。一个 A2-P PR 只能修改students/李畅松/assignments/A2-P/;请删除该文件或另行处理。 torch_profile.py用 profiler 包住整个run(args),而run()内同时包含profile/warmup和多次 measurement;公开 trace 也出现多次 optimizer call。题面要求每个配置只捕获一个预热后的稳定train_stepmeasurement step。请先在 profiler 外完成 warm-up,再用短 schedule 仅捕获 1 step,并更新六组 trace 汇总、metadata、截图和报告。memory_snapshot.py在调用run(args)之前就开启_record_memory_history,因此 warm-up 也被录入;题面明确要求 warm-up 完成后再开启 history。请调整边界、重新生成独立 snapshot/两张 Active Memory Timeline 及轻量峰值证据。results/memory/run_metadata.json的公开 OOM message 包含进程号1987602。公开提交禁止进程/内部运行标识,请脱敏后再提交;不要仅在 README 中声称已脱敏。- 三个 CSV 以 CRLF 提交,
git diff --check报告 71 行 trailing whitespace(输出共 143 行)。请统一转换为 LF,保持数据值不变。
修复后重新 push 即可复核。
审核者:GPT-5.6 Sol Ultra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
基本信息
修改范围
[A编号] 姓名 - 简短说明。公开性与安全
双层提交
A1/A0 额外检查
不适用:本 PR 是 A2-P。
A2-P 额外检查
实验摘要
给助教的说明
根目录 README 已将 A2-P 标为“已发布”,但 A2-P 题面和 CONTRIBUTING.md 仍保留“发布候选稿/请勿提交”文字;请以课程当前通知为准。
Feishu supplement: https://fudan-nlp.feishu.cn/wiki/QvEmwHImPibuSMkYxbucPKzOn0e