Skip to content

build: add libcurl-dev to Dockerfiles #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timosachsenberg merged 1 commit into from
Mar 6, 2026
Merged

build: add libcurl-dev to Dockerfiles #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dockerfiles/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ RUN apt-get -y update \
zlib1g-dev \
libxerces-c-dev \
libbz2-dev \
libcurl4-openssl-dev \
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== curl build configuration =="
rg -n -C2 'OPENMS_CONTRIB_BUILD_CURL|CURL_USE_OPENSSL|CURL_USE_SCHANNEL|CURL_USE_SECTRANSP' libraries.cmake/curl.cmake

echo
echo "== relevant Dockerfile packages =="
rg -n 'libcurl4-openssl-dev|libssl-dev' dockerfiles/Dockerfile

Repository: OpenMS/contrib

Length of output: 622

🏁 Script executed:

sed -n '15,40p' dockerfiles/Dockerfile | cat -n

Repository: OpenMS/contrib

Length of output: 826

🏁 Script executed:

rg -n 'libssl' dockerfiles/Dockerfile

Repository: OpenMS/contrib

Length of output: 40

Replace libcurl4-openssl-dev with libssl-dev on this line.

libcurl4-openssl-dev is already present on line 35. Since libraries.cmake/curl.cmake builds curl from source with -DCURL_USE_OPENSSL=ON, the required system dependency is OpenSSL development headers (libssl-dev), not a duplicate libcurl package. Without libssl-dev, the curl build will fail.

Proposed fix 
-    libcurl4-openssl-dev \
+    libssl-dev \
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
libcurl4-openssl-dev \
libssl-dev \
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@dockerfiles/Dockerfile` at line 22, Replace the duplicate package name
libcurl4-openssl-dev with libssl-dev in the apt packages list so the system
provides OpenSSL development headers required by the curl build; update the
packages list entry that currently reads libcurl4-openssl-dev to libssl-dev (the
other occurrence of libcurl4-openssl-dev on the file can remain) to ensure
libraries.cmake/curl.cmake can build with -DCURL_USE_OPENSSL=ON.

libomp-dev \
libhdf5-dev\
libboost-date-time1.74-dev \
Expand Down