fix(group): admin message dialog now loads member list#401
Merged
Conversation
The dialog was always showing an empty member list because actionGetGroupMembers() silently discarded API response data when groupStore.group was null. The composable now uses the returned data directly instead of reading from store state.
Some group members have null user records (deleted accounts or incomplete data). This crashed the Specific Members selector.
Dead state — added but never read by any consumer. The action's return value and this.group.groupMembers cover all callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionGetGroupMembers()silently discarded API response whengroupStore.groupwas null (which it always is when opened from the sticky menu)groupMembersstate property for other consumersContext
Reported by a group admin who couldn't message a new guest who requested to join. The "Specific Members" selector was a dead end — no members to select, send button greyed out.
Test plan