Skip to content

fix: improve favicon discovery for Edge and search crawlers#404

Merged
tompscanlan merged 1 commit into
OpenMeet-Team:mainfrom
Tharunraja7:fix/edge-favicon-discovery
Apr 1, 2026
Merged

fix: improve favicon discovery for Edge and search crawlers#404
tompscanlan merged 1 commit into
OpenMeet-Team:mainfrom
Tharunraja7:fix/edge-favicon-discovery

Conversation

@Tharunraja7

Copy link
Copy Markdown
Contributor

Why this PR?

The OpenMeet favicon is not visible in Microsoft Edge, while it appears correctly in other browsers.


Changes Made

  • Added explicit .ico favicon declaration in index.html
    • rel="icon" type="image/x-icon"
  • Ensured proper favicon discovery for browsers like Edge
  • Updated manifest icon URLs to point to /openmeet/icons/... - Added root-level favicon fallback assets in public/ - favicon.ico - favicon-32x32.png - favicon-16x16.png

Current Behavior (Edge)

Favicon is not visible in Microsoft Edge.


Screenshot

image

Feedback

Please let me know if any changes are needed.

@tompscanlan

Copy link
Copy Markdown
Contributor

Remove the 3 icon files from the commit. The existing icons referenced in the changes ought to handle it. The rest looks good to me.

@Tharunraja7 Tharunraja7 force-pushed the fix/edge-favicon-discovery branch from 2843bbb to ae53341 Compare March 31, 2026 16:42
@Tharunraja7

Copy link
Copy Markdown
Contributor Author

Removed the 3 icon files from the commit as suggested. The rest remains unchanged.

@Tharunraja7 Tharunraja7 force-pushed the fix/edge-favicon-discovery branch from 8ce8851 to ae53341 Compare March 31, 2026 18:38
@tompscanlan tompscanlan merged commit 7f3f887 into OpenMeet-Team:main Apr 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants