fix: /groups/create route and /favicon.ico for crawlers#406
Merged
Conversation
- Add redirect from /groups/create to DashboardGroupCreatePage, matching the existing /events/create pattern. Previously "create" was matched by the :slug param showing "Group not found". - Add explicit nginx location for /favicon.ico aliased to /openmeet/icons/favicon.ico so crawlers and Edge that probe the root path get the actual icon instead of the SPA shell.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/groups/createroute fix: Added a redirect from/groups/createtoDashboardGroupCreatePage. Previously, "create" was captured by the:slugdynamic param, showing "Group not found". This matches the existing/events/createpattern./favicon.icofor crawlers: Added explicit nginxlocation = /favicon.icoaliased to/openmeet/icons/favicon.ico. Crawlers and Edge that probe the root path were getting the SPA HTML shell instead of the actual icon.Test plan
/groups/create— should redirect to login (unauthenticated) or dashboard create page (authenticated)/groups/some-real-slug— should still load the group page normally/favicon.icoreturns the actual icon file (check content-type isimage/x-icon)/events,/events/create,/events/:slug