fix: update empty-state event button label for users with past events#412
Merged
tompscanlan merged 1 commit intoMay 28, 2026
Conversation
tompscanlan
approved these changes
May 28, 2026
tompscanlan
left a comment
Contributor
There was a problem hiding this comment.
Code reviewed: types verified (DashboardEventCounts.past exists), NoContentComponent accepts buttonLabel prop, computed logic is correct. Clean single-file change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for "Create your first event" label shown for users with past events (#409)
Updated the empty state logic in DashboardEventsPage.vue to display the correct button label based on whether the user has past events.
Changed the button label from a static value to a computed property.
Added a computed check for past events using summary.counts.past.
Before fix:
After fix:
Closes #409
Before fix :

After fix :
