ci: remove unused build-pr job from workflow#5
Merged
Conversation
The build-pr job pushed Docker images to ECR for pull requests, but: - These images were never used (no preview deployments) - Fork PRs fail because they can't access AWS secrets - The test job already validates code compiles and passes Now PRs only run tests. Images are built/pushed only on merge to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
build-prjob that was blocking fork PRs from getting green CI.Problem
build-prjob requires AWS credentials to push images to ECRSolution
Remove
build-prentirely. It pushed PR images that were never used (no preview deployments exist).What remains
testjob only (build, lint, unit tests)build-and-deploy+gitops-updateTest plan