Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lenaRB
As discussed during our last meeting, I starter cleaning up some of the changes I made.
So here is the first batch of changes (preserving java 1.8)
crml.compiler: Code related to translating CRML to Modelicacrml.langauge: Code related to parsing CRMLcrml.omc: Code related to running OpenModelicacrml.test: Test related stuff (I hope to eventually move it to/src/test/java)crml: Application code (main)crml.language.Parser. It has static functions to parse input fromFile,Path,StringandCharStream. Latter 2 expect the textual model, not a textual path. Return type is aParserResultthat wraps the related artifacts. (It was originally arecord, but that is not available in Java 1.8.)I have a few more question for the continuation:
languageandcompiler?maintotest? I plan to make the calls for the specific tests to make if that is ok.