Remove deprecated code in ModelicaSystem set*() functions #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
changed the title
This was referenced Aug 16, 2025
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
1f551fd to
9d33992
Compare
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
9d33992 to
ba56397
Compare
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
7698707 to
0144f48
Compare
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
0144f48 to
6acd4dd
Compare
Pylint is recommenting to order the imports in several sections alphabetically: (1) python standard library (2) third party packages (3) current package
OMPython/ModelicaSystem.py:1787:16: W0612: Unused variable 'key' (unused-variable) => replace items() by values()
…table * use check=False => no CalledProcessError exception; possibility to handle the error code * error code needs to be checked (compare == 0) by the caller! * improve log messages; print returncode if it is != 0 with stdout
* ensure a message if logged if returncode != 0
* self.session().run_model_executable() will raise OMCSessionException!
… (try-except-raise)
Would it make sense to combine this code and the code in linearize() in one new function? def _process_override_data(self, om_cmd, sim_override, file_override) -> None: The code could: (1) check the version; set command line parameters as needed (2) create the content of the override file (3) create the overwrite file and set it as command line parameter The advantage would be, that the modified code is not in two places but only in one ...
…ons as dict[str, str] * after OMC is run, the values will be string anyway * simplify code / align on one common definition for these dicts
* remove not needed variable definitions * fix if condition for bool
python-version: ['3.10', '3.12', '3.14'] os: ['ubuntu-latest', 'windows-latest'] omc-version: ['1.25.0', 'stable', 'nightly']
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
6acd4dd to
0d9e385
Compare
…mmand) the following classes are not changed - tehse are obsolete: - OMCSessionZMQ - OMCSessionCmd
syntron
force-pushed
the
remove_deprecated-ModelicaSystem_rewrite_set_functions
branch
from
0d9e385 to
b26b95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove old style input for set*() functions
see PR #314 and PR #345
this should be with milestone 5.0.0 (one release with the warning message)