Remove OMCSessionZMQ #387
Open
Remove OMCSessionZMQ #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
remove_OMCSessionZMQ
branch
from
3a851c2 to
4b7dfa7
Compare
syntron
force-pushed
the
remove_OMCSessionZMQ
branch
2 times, most recently
from
130a54b to
2918597
Compare
Pylint is recommenting to order the imports in several sections alphabetically: (1) python standard library (2) third party packages (3) current package
OMPython/ModelicaSystem.py:1787:16: W0612: Unused variable 'key' (unused-variable) => replace items() by values()
…table * use check=False => no CalledProcessError exception; possibility to handle the error code * error code needs to be checked (compare == 0) by the caller! * improve log messages; print returncode if it is != 0 with stdout
* ensure a message if logged if returncode != 0
* self.session().run_model_executable() will raise OMCSessionException!
… (try-except-raise)
Would it make sense to combine this code and the code in linearize() in one new function? def _process_override_data(self, om_cmd, sim_override, file_override) -> None: The code could: (1) check the version; set command line parameters as needed (2) create the content of the override file (3) create the overwrite file and set it as command line parameter The advantage would be, that the modified code is not in two places but only in one ...
…ons as dict[str, str] * after OMC is run, the values will be string anyway * simplify code / align on one common definition for these dicts
OMCSessionPort is a limited version as we do not know how OMC is run.
* remove not needed variable definitions * fix if condition for bool
python-version: ['3.10', '3.12', '3.14'] os: ['ubuntu-latest', 'windows-latest'] omc-version: ['1.25.0', 'stable', 'nightly']
syntron
force-pushed
the
remove_OMCSessionZMQ
branch
from
2918597 to
9ebd429
Compare
…mmand) the following classes are not changed - tehse are obsolete: - OMCSessionZMQ - OMCSessionCmd
syntron
force-pushed
the
remove_OMCSessionZMQ
branch
from
475cbbd to
93f2bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally remove OMCSessionZMQ
based on top of PR #386
milestone v5.0.0 (cleanup / removal of depreciated features)