Orchestrator Platform - #391
Merged
Merged
Conversation
leongross
reviewed
Aug 6, 2026
rusty1968
reviewed
Aug 6, 2026
rusty1968
reviewed
Aug 6, 2026
chrysh
force-pushed
the
fwmanager-docs
branch
2 times, most recently
from
August 6, 2026 20:17
7f41c9f to
1d12620
Compare
Collaborator
|
Overall, it tries to describe the entire orchestrator mission instead of focusing on the platform side of things. |
chrysh
force-pushed
the
fwmanager-docs
branch
2 times, most recently
from
August 7, 2026 09:52
8e05b19 to
349494b
Compare
Contributor
Author
Should be fixed now. |
leongross
requested changes
Aug 13, 2026
The platform half around the state-machine core: surrounding services, capability contracts, the board device table, and the fail-safe rules at the responsibility boundary.
Per review: services are reached syscall-like — the orchestrator issues an IPC call, the service does the hardware I/O on its behalf, and the data returns via IPC. Name the existing service crates in the diagram and add a legend showing the client / client-ipc / server round trip. Assisted-by: Claude (claude-fable-5)
Per review: decisions and the chain walk live in the state machine and are documented there. Drop the Responsibilities section that restated the mission; open with the sensors/actuators framing. Keep the SPI write-filter TOCTOU fact in the boundary section. Assisted-by: Claude:claude-fable-5
Per review: services provide facts, the state machine judges them. Relabel the SPI edge and add the facts-not-verdicts rule. Assisted-by: Claude:claude-fable-5
Rename the scope heading, access-not-touch wording, and link the services/i2c and services/mctp crates the layering paragraph cites. Signed-off-by: Christina Quast <christina.quast@9elements.com>
leongross
self-requested a review
August 17, 2026 12:16
leongross
approved these changes
Aug 17, 2026
leongross
left a comment
leongross
left a comment
Member
There was a problem hiding this comment.
Lgtm, let's get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of the fwmanager responsibilities and block diagram.