I2C DMA timeout does not quiesce the engine fix - #393
Open
JesseMelon wants to merge 2 commits into
Open
Conversation
JesseMelon
force-pushed
the
i2c-quiesce-engine
branch
from
August 4, 2026 17:07
a283f59 to
5d10ed8
Compare
JesseMelon
changed the title
rusty1968
force-pushed
the
i2c-quiesce-engine
branch
from
August 11, 2026 04:10
5d10ed8 to
6b2f6b4
Compare
rusty1968
self-requested a review
August 11, 2026 04:48
rusty1968
reviewed
Aug 11, 2026
rusty1968
left a comment
rusty1968
left a comment
Collaborator
There was a problem hiding this comment.
Please add targeted tests for the DMA guard: uncommitted drop must quiesce/reset, committed drop must be no-op, timeout path must auto-teardown, and busy-wait must remain bounded to avoid hangs.
Using type-state gets rid of the committed flag.
rusty1968
requested changes
Aug 11, 2026
JesseMelon
force-pushed
the
i2c-quiesce-engine
branch
from
August 14, 2026 22:30
6b2f6b4 to
eaa67cb
Compare
Drop the runtime `committed` flag from ArmedDma; commit(self) now consumes the guard via mem::forget, so a committed transfer is no longer a droppable value and Drop tears down unconditionally. Add the two-image i2c_dma_abort hardware test (master DMA + clock-stretching slave) exercising the commit no-op path and the timeout -> guard-drop -> soft-reset teardown path. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
JesseMelon
force-pushed
the
i2c-quiesce-engine
branch
from
August 14, 2026 22:33
eaa67cb to
083a997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.