v0.2.0 release tracking: packed-package smoke#2
Open
michaeljgrimm wants to merge 1 commit into
Open
Conversation
Verify the generated tarball installs cleanly and keep npm output source-map free for v0.2.0. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Author
|
CTO review for DAT-3880: approved from the Paperclip quality gate. Reviewed the packed-install smoke, CI wiring, source-map decision, and tarball evidence. The smoke validates root imports, focused imports, raw JSON imports, valid deck validation, invalid deck validation, required tarball entries, exclusion of source maps, and exclusion of No blocking findings. Note: I could not submit a formal GitHub approval because both the GitHub App and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.2.0 Release Tracking PR
This PR is the
v0.2.0release tracking PR for the OPF package work approved through DAT-3870.GitHub shows this PR as the Phase 3 diff only because Phase 1 and Phase 2 were already committed to
mainbefore this PR was opened. The fullv0.2.0delivery evidence is:5250430main94946bbmain895d1a0All-Phase PR Feasibility
A true all-phase PR against
mainis no longer possible without rewriting or revertingmain, becausemainalready contains the Phase 1 and Phase 2 commits. Any normal PR targetingmaincan only show commits and net file changes not already reachable frommain, so PR #2 correctly shows only the remaining Phase 3 diff.I do not recommend rewriting or reverting
mainjust to manufacture an all-phase PR. This tracking PR plus the commit list above is the accurate delivery record.Merge Recommendation
Recommendation: merge PR #2 after accepting this evidence trail. It is mergeable, and OPF CI succeeded on the Phase 3 head commit
895d1a0in OPF CI run #31.No additional PR is required before npm publish approval once PR #2 is merged. npm publish remains explicitly out of scope for this PR and requires separate approval.
Phase 3 Summary
@openpresentation/opf.tgz, and validates root imports, focused imports, raw JSON imports, valid deck validation, and invalid deck validation.sourcemap: falseand document focused import guidance for consumers that only need one OPF surface.Validation
corepack pnpm install --frozen-lockfilecorepack pnpm typecheckcorepack pnpm buildcorepack pnpm testcorepack pnpm --filter @openpresentation/opf pack:dry-runnode packages/javascript/test/packed-install-smoke.mjscorepack pnpm --filter @openpresentation/opf test:packedTarball Evidence
openpresentation-opf-0.2.0.tgz, package size798.9 kB, unpacked size4.8 MB,418files.openpresentation-opf-0.2.0.tgzat798885bytes and checked418tarball entries.dist/spec/schemas/opf.schema.json,dist/spec/catalogs/audiences/board.json, nodist/spec/openapi.yaml, and no.mapentries.Approval Status
CTO review for Phase 3 is recorded in the PR comments. A formal GitHub approval could not be submitted because the authenticated GitHub user is also the PR author and GitHub blocks self-approval; the GitHub App approval path also returned
Resource not accessible by integration.