test(runtime): bind wall readback to its predecessor - #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
Summary
Make the DSL-437 wall-clock concurrency regression assert the actual locked predecessor coordinate instead of assuming the driver must still be at absolute tick zero.
Scope: OpenRAE core only. No experiment code, data, or results are changed.
Requirement UIDs
DSL-437Related issues
Closes #1122
Related: #861
Because this PR targets
dev, issue closure may need to be reconciled manually when the change reaches the default branch.Stack
devat3d6e369b726607ff657a841c7f1dee0bec655b8fChanges
TimeCoordinateModelwhile the participant read lock is held.Compatibility and release impact
test:only).CHANGELOG.mdand the package version remain release-please owned.Verification
61 passed.Traceability
DSL-437 / #1122← concurrency decision addendum.DSL-437 / #1122← predecessor-bound wall readback regression.Checklist
Notes for review
This narrows the test oracle without weakening the core assertion: an advance during the protected read still changes the snapshot or returned coordinate and fails deterministically.