fix(processor): bound the complete solver operation (#1108) - #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
Summary
Build one deterministic incremental QF_LIA solver session per normalized model. Clauses and fixed witness choices are selected through temporary assumptions, preserving the incumbent initial decision, canonical witness order, and sorted-deletion core reduction without rebuilding the expression graph.
The governed 5,000 ms timeout is now one monotonic operation deadline beginning before solver construction. Every native check receives only the remaining time, and a result arriving after the deadline is rejected. The existing finite check-count budget remains an independent bound.
The shared check path also fails closed on Z3
unknown, preserves bounded operational context at the service boundary, rejects duplicate clause IDs before solver construction, and represents empty membership explicitly as false. No partial SAT/UNSAT, canonical-witness, or subset-minimal-core evidence is emitted after an incomplete check.Related issues
Closes #1108
Closes #1114
Related: #826 (closed governed-profile lineage). Prior proposal: #1083.
Changes
unknown, budget exhaustion, duplicate clause IDs, and deadline expiry through typed operational errorsTest plan
diff-coveragainstorigin/dev)_solver.pyis 100% line and branch covered, and all introduced_service.pybranches are covered/usr/bin/busyboxbuilder testnox -s verify: attempted; this macOS worktree lacks/usr/bin/busyboxfor host-specific libvirt tests and the pinned offline Isabelle acquisitionChecklist
Notes for review
devcommit3d6e369bafter merged PR feat: separate compute kind from realization substrate #1082.