fix: retry transient pinned tool downloads - #1140
Draft
doublewhy wants to merge 4 commits into
Draft
Conversation
doublewhy
force-pushed
the
fix/ci-download-retries
branch
5 times, most recently
from
August 13, 2026 03:24
e8cfcad to
ab2a94a
Compare
doublewhy
force-pushed
the
fix/ci-download-retries
branch
2 times, most recently
from
August 13, 2026 03:32
8ae3d5b to
5532cbf
Compare
doublewhy
force-pushed
the
fix/ci-download-retries
branch
from
August 13, 2026 03:47
5532cbf to
4a107f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
Closes #1137.
Integration status
#1113 and #1121 have merged. This branch is rebased onto
devat96b20ae8422fae9936bae928bbd8a1c14d2001daand includes both changes.tools/http_download.pyadded by feat: add source-neutral SDL candidate synthesis #1113 no longer contains a second retry implementation. It delegates to the governed release downloader and caps legacy attempt, timeout, and size options at the new policy.No #1113 or #1121 supply-chain control is duplicated, bypassed, or relaxed. No integration dependency on those merged changes remains. This PR stays draft and intentionally last in the current merge order while lower-layer CI and tooling PRs advance; all exact-head required checks are green.
What changed
Retry-After, and 256 MiB per response.release-assets.githubusercontent.comproduction-asset path. Signed final-asset queries are never logged, redirect bodies are never drained, and the asset host cannot redirect onward.Locationtext.Verification
On exact rebased head
4a107f7a05f9304ad7a51e22db2904b4cfd5d1ae:282 passed, 1 deselectedacross the feat: add source-neutral SDL candidate synthesis #1113 compatibility, retry, wrapper, and repository-tool test files.tools/release_download.py: 452/452 statements and 150/150 branch exits covered (100%).tools/http_download.py: 26/26 statements and 10/10 branch exits covered (100%).osv_scanNox session passes against the current frozen lockfile.31664978450passed verify, fuzz, Docker integration, supply-chain, and Sonar; Docs run31664978515and CodeQL run31664975690passed; title guard and GitGuardian passed. The PR-only deploy job was intentionally skipped.The unchanged governed retry core previously passed its focused suite under Python 3.11, 3.12, 3.13, and 3.14. A dependency-isolated Python 3.15.0a8 run also passed it; full Python 3.15 project qualification remains separate in #1134.
Security and compatibility
No tool version, digest, checksum source, initial GitHub repository, cache path, archive rule, command line, or CI gate is weakened or changed. The legacy
download_bytesAPI remains available but delegates to the sole governed implementation and cannot exceed its three-attempt, 60-second per-read, or 256 MiB limits. Exhausted transient failures remain hard failures.