fix: backfill schema-publication ledger entries to unblock dev->main - #555
Merged
Conversation
…amily The last_change change-ledger requirement in check_schema_publication.py (ADR-009 section 7, _check_change_ledger) was introduced on dev after the participant backend-facing contract family (ADR-060, issue #76) and the DSL-132/DSL-141 datastore additions had already landed. Per-PR CI compares schemas against dev, so those schema changes never required a ledger entry; the dev->main PR (#545) is the first evaluation against main, where all 11 schemas read as changed and the gate fails. Backfill a contract-facing last_change entry (summary + current content_hash) for each of the 11 affected published schemas so the dev->main schema publication gate passes. No schema content changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the
dev → mainintegration PR #545, whoseverifyjob fails at thecontracts / schema publication manifestgate.Root cause
The
last_changechange-ledger requirement intools/check_schema_publication.py(
_check_change_ledger, ADR-009 §7) was introduced ondev(commit5e77a5d)and does not exist on
main. The gate requires a contract-facinglast_changeentry for any published schema whose content differs from the comparison base.
Per-PR CI compares schemas against
dev, so the participant backend-facingcontract family (ADR-060, issue #76) and the DSL-132/DSL-141 datastore additions
— which all landed before the gate — never required a ledger entry. PR #545
(
dev → main) is the first time the schema delta is evaluated againstmain,where all 11 read as changed and the gate fails with "changed without a
contract-facing change description".
This is pre-gate schema-evolution debt surfaced at the integration boundary, not
a regression in any single feature PR.
Change
Backfill a
last_changeentry (a contract-facingsummary+ the schema's currentcanonical
content_hash) for the 11 affected published schemas incontracts/schema-publication-manifest.json:backend-manifest-v2,backend-profile-v1(API-407 manifest/profile extension)sdl-authoring-input-v1(DSL-132/DSL-141 datastore-node surface)participant-{context,history,status}-view-v1,participant-{lifecycle-event,observation-envelope,outcome-report,shared-state-record}-v1,participant-behavior-history-event-stream-v1No schema content changes — only ledger metadata. Each
last_change.content_hashequals the entry's existing
content_hash(already validated against the schema file).Verification
python tools/check_schema_publication.py --base-rev origin/main→ exit 0 (reproduces and clears Dev #545's failing check)tools/check_repo_policy.py --base-rev origin/dev→ passtools/check_generated_schemas.py→ pass; JSON validOnce this merges to
dev, re-run #545's checks and the schema-publication gate passes; aftermaincarries these schemas the gate will not re-fire for them.