refactor(conformance): drop redundant tuple() constructors (S7496) - #746
Merged
Conversation
…S7496) SonarCloud activated python:S7496 and flagged the dev->main promotion (PR #740) on tuple((*a, *b)) in aces_conformance/conformance.py, where the inner starred expression is already a tuple. Unwrap both occurrences. No behaviour change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
The
dev→mainpromotion (PR #740) now fails SonarCloud on a single newviolation —
python:S7496"Remove the redundant tuple constructor call" ataces_conformance/conformance.py. SonarCloud activated this rule since the earlierscans, and it flags
tuple((*a, *b))where the inner starred expression is alreadya tuple. (Not from the modularity split in #743 — this line came in with #741.)
What
Unwrap both occurrences in
conformance.py:Semantically identical (
(*a, *b)is already a tuple); thetuple(...)wrapper ispure redundancy.
Verification
ruff check/formatclean; conformance test suite green (83 passed).new_violationson PR Dev #740 (was 1).Requirement: MOD-001 (code-quality cleanup).