Skip to content

refactor: clear PR 753 Sonar findings - #759

Merged
Brad-Edwards merged 1 commit into
devfrom
MOD-001-pr-753-sonar
Jul 13, 2026
Merged

refactor: clear PR 753 Sonar findings#759
Brad-Edwards merged 1 commit into
devfrom
MOD-001-pr-753-sonar

Conversation

@Brad-Edwards

@Brad-Edwards Brad-Edwards commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reduce aces_mcp.tools.reference below Sonar's 500-line file limit and remove its stale oversized-file allowlist entry
  • split raw schema construction from schema decoration so both functions remain below Sonar's 100-line function limit
  • replace repeated planner resource collection blocks with an order-preserving table-driven loop

Why

PR #753 merged dev into main, but its SonarCloud quality gate reported three new maintainability violations (python:S104 and python:S138). This behavior-preserving refactor clears those violations so the next dev promotion can pass the strict zero-new-issues gate.

Impact

No contract, schema, planner ordering, or MCP response behavior changes. The patch only reduces source and function size.

Requirement Context

  • Requirement UID: MOD-001
  • Related PR: Dev #753

Validation

  • full tools/verify_all.py graph: passed
  • 3,650 unit tests passed; 1 skipped; 46 deselected
  • 34 integration tests passed; 2 environment-dependent libvirt tests skipped
  • 92% aggregate coverage
  • policy, hygiene, lint, schema drift, contract validation, and docs build passed

@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards marked this pull request as ready for review July 13, 2026 03:54
@Brad-Edwards
Brad-Edwards merged commit 3e84aa9 into dev Jul 13, 2026
14 checks passed
@Brad-Edwards
Brad-Edwards deleted the MOD-001-pr-753-sonar branch July 13, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant