Dev - #771
Merged
Merged
Conversation
* refactor: split processor models.py into a subdomain package Convert the 4343-line implementations/python/packages/aces_processor/models.py into a models/ package of 13 cohesive subdomain modules (each within the 500-line ADR-015 cap) behind an API-stable re-export facade in models/__init__.py. Pure refactor with no behavior change: definitions are moved byte-for-byte, every external `from aces_processor.models import ...` line is unchanged, and the full public surface (116 names, including the shared-contract re-exports) is preserved. Two private helpers (_optional_payload_string and the observation-detail constants) move to behavior_resources so all cross-module imports are forward-only, avoiding import cycles. Remove the split file from tools/policy/oversized_allowlist.yaml and repoint the now-stale models.py artifact references in the semantic-coverage matrix, the assurance-fulfillment record, the formal specs, and the Sonar S1128 ignore to the new package. * refactor: resolve SonarCloud new-code findings from the models split Clear all 57 SonarCloud new_violations that the byte-for-byte split surfaced as "new" code, with zero rule suppressions: - Replace bare `Any` parameter hints with `object` on JSON/dynamic boundaries (S6542). - Reduce cyclomatic and cognitive complexity of the moved functions via behavior-preserving helper extraction (FunctionComplexity, S3776), and fix S1142/S3358/S7494. - Bundle iter_participant_behavior_history_violations' two compiled address-set parameters into a new ParticipantHistoryAddressScope dataclass to satisfy S107; update the aces_conformance caller and the SEM-208/211/212 test call sites accordingly. The complexity helpers pushed four modules past the 500-line ADR-015 cap, so extract three cohesive sibling modules along the existing forward-import order: outcome_interpretation_validation, behavior_anchor_index, and history_event_grounding. Every models module is now <= 500 lines; the public API is unchanged except the intentional ParticipantHistoryAddressScope restructure. No behavior change beyond that restructure: the existing test suite is green and violation message ordering/content is preserved throughout. * docs: document aces_processor.models subdomains after the package split The models package __init__ re-exports the public surface; documenting it with automodule + the new __all__ made autodoc re-emit the re-exported aces_contracts DTOs (Diagnostic, RuntimeSnapshot, ...) as duplicate py-domain targets, which the -W docs build rejects as ambiguous cross-references. Document the subdomain modules that define the classes instead, so autodoc filters imported members by __module__. * refactor: clear residual SonarCloud new-code findings - _participant_episode_histories_from_source returned tuples of differing arity ((x,) vs ()); return lists instead so the iterate-only result no longer trips S8495. Behavior is unchanged (callers only iterate it). - Give the _iter_validated_participant_behavior_violations history parameter an explicit list[Any] argument to satisfy S6543.
* chore(main): release 0.19.0 * chore(main): release 0.19.1 * chore(main): release 0.20.0 --------- Co-authored-by: Brad Edwards <j.bradley.edwards@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Clarify runtime contract evidence boundary
* Define Node service reachability semantics * Fix SonarCloud findings (cycle 1) * Fix SonarCloud findings (cycle 2)
Rebuild related-work comparison with reproducible evidence
* Add scoped realization posture cascade * Fix SonarCloud findings (cycle 1) * Fix SonarCloud findings (cycle 2)
* Define behavioral relation taxonomy and claim discipline * Fix SonarCloud findings (cycle 1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Requirement Context
aces-sdlChanges
Test Plan
uvx nox -s verifypasses, or the unchecked sessions are listed belowuvx nox -s docs)Checklist
docs/explain/reference/coding-standards.md)CHANGELOG.mdfrom it)Notes for Review