Skip to content

Dev - #781

Merged
Brad-Edwards merged 7 commits into
mainfrom
dev
Jul 15, 2026
Merged

Dev#781
Brad-Edwards merged 7 commits into
mainfrom
dev

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

Related Issues

Requirement Context

  • Requirement UID:
  • ADRs touched:
  • Ground Control project: aces-sdl

Changes

Test Plan

  • Relevant tests pass
  • uvx nox -s verify passes, or the unchecked sessions are listed below
  • Docs build passes when documentation changed (uvx nox -s docs)

Checklist

  • Code follows project coding standards (docs/explain/reference/coding-standards.md)
  • FM level classified if semantic change
  • Published contract schemas regenerated if models changed
  • PR title is a Conventional Commit (release-please derives the version and CHANGELOG.md from it)
  • Architectural docs updated if applicable

Notes for Review

Brad-Edwards and others added 7 commits July 13, 2026 18:45
* Add authored identity domain topology

* Fix SonarCloud findings (cycle 1)

* Fix SonarCloud findings (cycle 1)
* chore(main): release 0.19.0

* chore(main): release 0.19.1

* chore(main): release 0.20.0

* chore(main): release 0.21.0

---------

Co-authored-by: Brad Edwards <j.bradley.edwards@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Validate SDL prose and reference contracts
Define participant decision-surface semantics
* Add realization honesty conformance

* Fix SonarCloud findings (cycle 1)

* Fix SonarCloud findings (cycle 2)
* refactor: split aces_processor/compiler.py into a package

Convert the 2677-line compiler module into an API-stable compiler/ package of
<=500-line submodules (foundations -> domain compilers -> pipeline -> facade).
No behavior change: public API (compile_runtime_model,
compile_scenario_runtime_model) and every external import line are unchanged,
and the existing test suite passes untouched. Drop the oversized-allowlist
entry and remove three unreachable private helpers. Update doc/spec path
references to the deleted file. Part of #3.

* Fix SonarCloud new-code findings from compiler split

The file split re-scans the moved code as new code, so pre-existing
maintainability issues surfaced as new violations. Resolve them without
behavior change: replace bare `Any` parameter hints with the concrete SDL
types (`object` for the polymorphic `_dump`), collapse the two outcome-address
if-chains into dict lookups, fold `_resolve_node_ref`'s require_vm/require_switch
into a single `required_type` (fewer params and returns), bundle
`_compile_workflow_step`'s loop-invariant arguments into a context object, and
decompose `_compile_action_contracts` into small extraction helpers. The test
suite is unchanged and green.
@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards merged commit 7d2afa6 into main Jul 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant