Skip to content

Update ManagerServant.cpp#1196

Open
n-ando wants to merge 1 commit intomasterfrom
rtcd2_docker_patch
Open

Update ManagerServant.cpp#1196
n-ando wants to merge 1 commit intomasterfrom
rtcd2_docker_patch

Conversation

@n-ando
Copy link

@n-ando n-ando commented Sep 25, 2025

rtcd's module_name option for rtcd2_docker command.

Identify the Bug

rtcd's "create" operation is inherited by the child "rtcd,"; however, "module_name" is not included in the argument. Because of this, the child "rtcd" does not know its launched components module name.

Description of the Change

This patch ensures that the "create" operation call includes the "module_name" option.

Verification

  • Did you succeed the build?
  • No warnings for the build?
  • Have you passed the unit tests?

rtcd's module_name option for rtcd2_docker command.
@Nobu19800
Copy link

この変更について、create_componentの引数にどういう文字列を与えたら、どういう結果になるのが正しいかを教えてもらえないでしょうか。
動作確認したのですが、create_component("RTC:::ConsoleIn:C++:?manager_name=manager_%p&config_file=rtc.conf")を実行すると、"module_name":RTC:::ConsoleIn:C++:?manager_name=manager_%pのオプションを設定したのですが、これは正しいですか?

@n-ando
Copy link
Author

n-ando commented Dec 1, 2025

--- a/src/lib/rtm/ManagerServant.cpp
+++ b/src/lib/rtm/ManagerServant.cpp
@@ -1240,6 +1240,10 @@ namespace RTM
         rtcd_cmd += " -o \"manager.instance_name:" + mgrstr + "\"";
         rtcd_cmd += " -o \"manager.shutdown_auto:NO\"";
 
+        coil::vstring tmp = coil::split (create_arg, "?");
+        rtcd_cmd += " -o \"module_name:" + tmp[0] + "\"";
+        RTC_DEBUG(("module_name: %s", tmp[0].c_str()));
+
 
         coil::vstring slaves_names;
         if (mgrstr == "manager_%p")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants