Skip to content

website redesign - #337

Open
Uriel-Sautron wants to merge 10 commits into
masterfrom
usn/website-redesign
Open

website redesign#337
Uriel-Sautron wants to merge 10 commits into
masterfrom
usn/website-redesign

Conversation

@Uriel-Sautron

Copy link
Copy Markdown
Contributor

This PR is the same as #304

@1eenaa
1eenaa requested review from Akctarus and younesschrifi May 29, 2026 08:48
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 8ba35a1 to 84ba8f2 Compare May 29, 2026 14:12
This reverts commit bd131fd.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 020560b.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 443fde6.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 2290493.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 798dc60.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 4280631.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 033ae98.

Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@younesschrifi
younesschrifi force-pushed the usn/website-redesign branch from cd50a02 to 3bd0827 Compare June 3, 2026 12:45
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 3bd0827 to d551b3f Compare June 3, 2026 13:03
1eenaa added 2 commits June 3, 2026 15:07
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from d551b3f to f258b38 Compare June 3, 2026 13:08

@Akctarus Akctarus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, otherwise, responsive works very well, good job!

  • github link and language choice should be interchanges, also, there should be a wider gap between these two items and the rest of the header
Image
  • below 640px, the carousel should take the full width
Image
  • when the page is small, the footer should have items displayed like that, not aligned
Image

@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 3bd7fdc to 27c64f9 Compare June 12, 2026 12:57
@younesschrifi
younesschrifi requested a review from Akctarus June 12, 2026 12:58
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 27c64f9 to b022885 Compare June 12, 2026 13:56
Comment thread content/_index.en.html
Comment thread content/_index.en.html
Comment thread assets/scss/_variables_project.scss Outdated
@1eenaa
1eenaa force-pushed the usn/website-redesign branch 4 times, most recently from 1afa608 to dafff2e Compare June 18, 2026 11:48
Comment thread assets/scss/_variables_project.scss Outdated
Comment thread assets/scss/_variables_project.scss Outdated
@younesschrifi
younesschrifi requested a review from Akctarus June 22, 2026 08:38
@1eenaa
1eenaa force-pushed the usn/website-redesign branch 3 times, most recently from 9dd0659 to f9f58af Compare July 1, 2026 13:57
@Akctarus
Akctarus self-requested a review July 1, 2026 14:40
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from f9f58af to 7f1a577 Compare July 1, 2026 15:19
Comment thread assets/scss/_variables_project.scss
Comment thread assets/scss/_variables_project.scss
Comment thread assets/scss/_variables_project.scss Outdated
Comment thread assets/scss/_variables_project.scss
Comment thread assets/scss/_variables_project.scss Outdated

@theocrsb theocrsb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it’s much better. Thanks
The result is getting closer to the mock-up!
We still need to take the comments on board and do some clean-up to ensure there are no CSS rules that have no impact on the app.

@theocrsb theocrsb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to organise the @media rules in ascending order, for example, and place them below the basic CSS to ensure a logical structure.

@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 7f1a577 to b33ba4b Compare July 2, 2026 11:49
@theocrsb
theocrsb requested a review from SarahBellaha July 2, 2026 12:57
@1eenaa

1eenaa commented Jul 2, 2026

Copy link
Copy Markdown

After validation with @thibautsailly , the navbar-link titles font-weight was changed to 600. This does introduce a scrollbar at the extreme 333px viewport width, but that width is rare enough that it's an acceptable trade-off.

@theocrsb theocrsb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under 639px =>
app:
Image

mockup:
Image

Generally speaking, the size of the footer keeps changing, even though there are three sizes defined in the mockup

@theocrsb

theocrsb commented Jul 2, 2026

Copy link
Copy Markdown

Below 639px, the sponsor div does not have the same background colour as in the mockup

image

The size must be set to 416px

@1eenaa
1eenaa force-pushed the usn/website-redesign branch 2 times, most recently from 017bd36 to bfb7791 Compare July 2, 2026 15:41
@SarahBellaha
SarahBellaha requested review from Math-R and removed request for SarahBellaha July 2, 2026 15:51
@1eenaa
1eenaa force-pushed the usn/website-redesign branch 3 times, most recently from 547c0b5 to 5712f9f Compare July 3, 2026 09:24
@1eenaa
1eenaa requested a review from theocrsb July 3, 2026 11:49
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
@1eenaa
1eenaa force-pushed the usn/website-redesign branch from 5712f9f to 4f0d311 Compare July 3, 2026 12:05

@Akctarus Akctarus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in overall, thank you for this PR!

@theocrsb theocrsb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking my comments on board.
The final result looks to me as though it matches the mockup.
There are still two or three minor points that could be improved in the CSS, but overall it’s fine by me.

@Math-R Math-R left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :) nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants