website redesign - #337
Conversation
7fd56f5 to
56d5f08
Compare
8ba35a1 to
84ba8f2
Compare
This reverts commit bd131fd. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 020560b. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 443fde6. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 2290493. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 798dc60. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 4280631. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
This reverts commit 033ae98. Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
cd50a02 to
3bd0827
Compare
3bd0827 to
d551b3f
Compare
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
d551b3f to
f258b38
Compare
Akctarus
left a comment
There was a problem hiding this comment.
Left few comments, otherwise, responsive works very well, good job!
- github link and language choice should be interchanges, also, there should be a wider gap between these two items and the rest of the header
- below 640px, the carousel should take the full width
- when the page is small, the footer should have items displayed like that, not aligned
3bd7fdc to
27c64f9
Compare
27c64f9 to
b022885
Compare
1afa608 to
dafff2e
Compare
9dd0659 to
f9f58af
Compare
f9f58af to
7f1a577
Compare
theocrsb
left a comment
There was a problem hiding this comment.
Overall, it’s much better. Thanks
The result is getting closer to the mock-up!
We still need to take the comments on board and do some clean-up to ensure there are no CSS rules that have no impact on the app.
theocrsb
left a comment
There was a problem hiding this comment.
It would be a good idea to organise the @media rules in ascending order, for example, and place them below the basic CSS to ensure a logical structure.
7f1a577 to
b33ba4b
Compare
|
After validation with @thibautsailly , the navbar-link titles font-weight was changed to 600. This does introduce a scrollbar at the extreme 333px viewport width, but that width is rare enough that it's an acceptable trade-off. |
017bd36 to
bfb7791
Compare
547c0b5 to
5712f9f
Compare
Signed-off-by: Lina AKRAD <lina.akrad@gmail.com>
5712f9f to
4f0d311
Compare
Akctarus
left a comment
There was a problem hiding this comment.
LGTM in overall, thank you for this PR!
theocrsb
left a comment
There was a problem hiding this comment.
Thank you for taking my comments on board.
The final result looks to me as though it matches the mockup.
There are still two or three minor points that could be improved in the CSS, but overall it’s fine by me.



This PR is the same as #304