doc: add doc for osm-to-railjson - #344
Merged
Merged
Conversation
SaumonDesMers
requested review from
Tristramg,
celine-sncf,
louisgreiner and
mcho75
June 29, 2026 12:34
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
3 times, most recently
from
July 1, 2026 07:13
67ac224 to
0a3eaf5
Compare
louisgreiner
reviewed
Jul 1, 2026
louisgreiner
left a comment
louisgreiner
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for taking the time to write down this, this is very valuable.
A lot of nit picking, feel free to ignore what you feel unrelevant!
Do not forget to generate the french version as well when the english one is fully reviewed.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
2 times, most recently
from
July 1, 2026 12:09
61cb664 to
66928f3
Compare
louisgreiner
reviewed
Jul 1, 2026
louisgreiner
reviewed
Jul 1, 2026
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
from
July 1, 2026 12:32
639b3e7 to
3864375
Compare
celine-sncf
approved these changes
Jul 1, 2026
celine-sncf
left a comment
celine-sncf
left a comment
Contributor
There was a problem hiding this comment.
Overall very clear and easy to read.
I feel like there is some superposition between the pages"Working with OSM data" and "osm-to-railjson" and that the two pages could maybe be merged into one, but it's not a strong opinion.
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
from
July 2, 2026 13:35
7267dfd to
6a016b4
Compare
mcho75
approved these changes
Jul 2, 2026
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
from
July 2, 2026 15:55
cf89520 to
08624d7
Compare
Signed-off-by: Simon <sim.gaubert.sg@gmail.com>
SaumonDesMers
force-pushed
the
sga/osm2railjson_doc
branch
from
July 3, 2026 14:17
4a07a26 to
697f5e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add doc for potential user to explain how to generate an infra and what are the issues related to working with open data.
Add more technical doc for dev about osm-to-railjson.