Open
Conversation
la14-1
force-pushed
the
qa/dedup-scanner
branch
from
e69c41d to
88cc613
Compare
Member
Author
|
Added commit: rename ambiguous duplicate test names across 9 test files. Multiple test files had identical Files updated: 1974/1974 tests pass. |
- update-check.test.ts: fix 3 tests using stale hardcoded version '0.2.3'
(older than current 0.29.1) to use `pkg.version` so 'should not update
when up to date' actually tests the current-version path correctly
- run-path-credential-display.test.ts: strengthen weak `toBeDefined()`
assertion on digitalocean hint to `toContain('Simple cloud hosting')`,
making it verify the actual fallback hint content
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
la14-1
force-pushed
the
qa/dedup-scanner
branch
from
fd3c783 to
6ccfa04
Compare
…rsive-spawn Two tests in recursive-spawn.test.ts captured console.log output into a logs array but never asserted against it. Both ended with a comment like "should not throw" — meaning they only proved the function didn't crash, not that it produced the right output. - "shows empty message when no history": now spies on p.log.info and asserts cmdTree() emits "No spawn history found." - "shows flat message when no parent-child relationships": now asserts cmdTree() emits "no parent-child relationships" via p.log.info. expect() call count: 4831 to 4834 (+3 real assertions added). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd-list-cov.test.tsthat used weaktoHaveBeenCalled()assertions with no content verification, all superseded by stronger tests in the same fileDetails
The removed tests called
cmdList()and only checkedexpect(clack.logInfo).toHaveBeenCalled()orexpect(consoleMocks.log).toHaveBeenCalled()— these only prove no exception was thrown, not that the function produces correct output.Each removed test had a stronger equivalent already present in the same file:
"shows empty message when no history"(line 106) →"shows no spawns message without filters"checksmsg.includes("No spawns recorded")"shows filtered results with agent filter"(line 139) →"shows filtered footer with agent filter"checks actual footer content"shows empty message with agent filter that matches nothing"(line 203) →"shows filter mismatch message with agent filter"checksmsg.includes("No spawns found matching")The 2 retained cloud-filter tests were upgraded from
toHaveBeenCalled()to content assertions verifying actual output (server names, error messages).Net: 3 tests removed, 2 tests strengthened. 1948/1948 tests pass.
-- qa/dedup-scanner