256 Multiwres are not written to vtk files#257
Merged
Conversation
Implementation of changes necessary to have vtk files contain multiwires
…er of (future) bundles in mtln_t
…geom and forward info to observation
… multiwires. Embedding in structures not done. Test passes
Alberto-o
commented
Jan 27, 2026
|
|
||
|
|
||
|
|
||
| !preanalisis de hilos embeddeds en materiales antes de asignarlos |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what is the goal of the block of code starting at line 1992 "preanalisis de hilos embeddeds en materiales antes de asignarlos".
It seems it is just giving a warning, but not stopping execution, when a wire meets the requirements to be "embedded"
Collaborator
There was a problem hiding this comment.
I make a quick scan of the block. I suggest its extraction into a subroutine to remove future missleading
…ire tests. Adds two tests with intermediate segments.
…written-to-vtk-files
…written-to-vtk-files
lmdiazangulo
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of changes necessary to have vtk files contain multiwires (#256)