fix(spp_analytics): rename legacy groups_id to group_ids for Odoo 19#216
Open
kneckinator wants to merge 1 commit into
Open
fix(spp_analytics): rename legacy groups_id to group_ids for Odoo 19#216kneckinator wants to merge 1 commit into
kneckinator wants to merge 1 commit into
Conversation
The res.users field was renamed from groups_id to group_ids in Odoo 19; the test helper still used the pre-19 name, which would fail at user creation time.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates spp_analytics/tests/test_integration_demo.py to rename the groups_id field to group_ids across multiple test cases, ensuring consistency with the expected schema. There are no review comments to address, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #216 +/- ##
==========================================
+ Coverage 71.27% 71.55% +0.28%
==========================================
Files 976 977 +1
Lines 57736 58269 +533
==========================================
+ Hits 41150 41696 +546
+ Misses 16586 16573 -13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
res.usersfield was renamed fromgroups_idtogroup_idsin Odoo 19, butspp_analytics/tests/test_integration_demo.pystill used the pre-19 name in threeres.users.create()calls (lines 252, 426, 636), which would fail at test setup time.(6, 0, [...])tuple form is preserved to match surrounding style.Test plan
spp_analyticstest suite —TestAggregationIntegrationDemouser creations should succeed (previously raised on the unknowngroups_idfield).groups_idreferences insidespp_analytics/(grep -rn groups_id spp_analytics/returns nothing).