feat: .NET 11#339
Draft
hhvrc wants to merge 7 commits into
Draft
Conversation
Prerequisite for adopting C# union types (discriminated unions), which ship as a preview language feature in .NET 11.
Converts every OneOf<T0,...>/OneOf.Types usage to C# union declarations (union keyword, LangVersion=preview), the structural-union language feature shipped in .NET 11 Preview 2. - Common/Results/Unions.cs: generic Union2<T0,T1>..Union8<..> declarations replacing OneOf<T0,...T7>. - Common/Results/CommonResultCases.cs: Success, Success<T>, NotFound, Error, Error<T>, None replacing OneOf.Types. - Rewrote every .Match/.Switch/.TryPickTx/.AsTx/.IsTx call site to switch expressions/statements and `is` patterns, since union declarations only expose a Value property plus constructors (no generated helper methods). - Removed the OneOf package reference from Common.csproj and Directory.Packages.props. Note: OpenShock.Common.Results.NotFound/Unauthorized share a name with inherited ControllerBase.NotFound()/.Unauthorized() methods, so a few controller files alias the namespace (`using Results = ...`) to disambiguate bare switch-pattern usage.
Enables the runtime-async feature switch solution-wide so async methods suspend/resume via the runtime instead of compiler-generated state machines: cleaner stack traces, better debuggability, lower overhead. No source changes needed - this only affects codegen.
|
Ready to review this PR? Stage has broken it down into 8 individual chapters for you: 
Chapters generated by Stage for commit a116dc4 on Jul 17, 2026 8:22pm UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.