Skip to content

feat: improve accessibility for course progress bars #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singhankit001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: improve accessibility for course progress bars #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/components/CourseProgress/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,11 @@ export default function CourseProgress() {
<div className={styles.courseTitle}>{course.title}</div>
<div className={styles.progressBarContainer}>
<div
role="progressbar"
aria-valuenow={Math.round(courseProgress)}
aria-valuemin="0"
aria-valuemax="100"
aria-label={`Progress: ${Math.round(courseProgress)}%`}
className={styles.progressBar}
style={{ width: `${courseProgress}%` }}
/>
Expand Down Expand Up @@ -245,6 +250,11 @@ export default function CourseProgress() {
</div>
<div className={styles.progressBarContainer}>
<div
role="progressbar"
aria-valuenow={Math.round(progress)}
aria-valuemin="0"
aria-valuemax="100"
aria-label={`Total Progress: ${Math.round(progress)}%`}
className={clsx(styles.progressBar, styles.mainProgressBar)}
style={{ width: `${progress}%` }}
/>
Expand Down Expand Up @@ -273,6 +283,11 @@ export default function CourseProgress() {
</div>
<div className={styles.progressBarFull}>
<div
role="progressbar"
aria-valuenow={Math.round(progress)}
aria-valuemin="0"
aria-valuemax="100"
aria-label={`Overall Course Progress: ${Math.round(progress)}%`}
className={styles.progressBarFill}
style={{ width: `${progress}%` }}
/>
Expand Down
Loading