Skip to content

fix: guard WinHttp URL port parsing exceptions #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
H-Chris233 wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix: guard WinHttp URL port parsing exceptions #60

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0800057
fix: guard WinHttp URL port parsing exceptions
H-Chris233 May 25, 2026
9447675
Merge branch 'main' into fix-winhttp-port-parse-guard
H-Chris233 May 26, 2026
37823b9
fix: reject partial-numeric port strings in ParseUrl
H-Chris233 May 26, 2026
f889019
Merge branch 'main' into fix-winhttp-port-parse-guard
H-Chris233 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Utils/WinHttp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,15 @@ namespace WinHttp {
size_t colon = hostPart.find(':');
if (colon != std::string::npos) {
out.host = std::wstring(hostPart.begin(), hostPart.begin() + colon);
out.port = static_cast<INTERNET_PORT>(std::stoi(hostPart.substr(colon + 1)));
auto portStr = hostPart.substr(colon + 1);
try {
size_t end = 0;
long port = std::stol(portStr, &end);
if (end != portStr.size() || port <= 0 || port > 65535) return out;
out.port = static_cast<INTERNET_PORT>(port);
} catch (...) {
return out;
}
} else {
out.host = std::wstring(hostPart.begin(), hostPart.end());
}
Expand Down
Loading