Skip to content

Feature: Support For Reversed Polarity HE Trigger Add-on#1609

Merged
arntsonl merged 16 commits intoOpenStickCommunity:mainfrom
j-wut:feature/he_trigger_polarity
Feb 23, 2026
Merged

Feature: Support For Reversed Polarity HE Trigger Add-on#1609
arntsonl merged 16 commits intoOpenStickCommunity:mainfrom
j-wut:feature/he_trigger_polarity

Conversation

@j-wut
Copy link
Contributor

@j-wut j-wut commented Feb 17, 2026

Reverse Polarity Support:

  1. Renamed some variables to make sense with polarity change (ie: pressed, instead of max)
  2. Renamed the Endpoints, getVoltage to get voltage, set Calibrations to set trigger settings.
  3. Logic for Reverse Polarity (doing a similar strategy to Pokemon trick room logic, subtracting compared voltages and thresholds from ADC_MAX before comparison)

Rapid Trigger Support:

  1. keeping state per channel for active state and previous voltage (to determine if the button is being pressed or released)
  2. using previous state and voltage to determine if gamepad state should be active or idle
  3. updating ui to add rapid trigger settings in calibration modal
  4. mirroring logic in ui to accurately represent if trigger will be active/inactive

Refactoring:

  1. Fixed some initialization in the he_triggers.h file
  2. additional refactoring of code in the HETrigger Addon UI (based on my code style preferences, feel free to give opinions, I am willing to change code style if you have a strong reason)

Test Evidence:
https://youtu.be/C1dSXA4BfJc
https://youtu.be/5awZCg9uq2s
https://youtube.com/shorts/bbVyIoNNNvQ

@j-wut j-wut force-pushed the feature/he_trigger_polarity branch from 5183035 to acf049e Compare February 17, 2026 17:41
@j-wut j-wut closed this Feb 19, 2026
@j-wut j-wut deleted the feature/he_trigger_polarity branch February 19, 2026 01:28
@j-wut j-wut restored the feature/he_trigger_polarity branch February 19, 2026 02:05
@j-wut j-wut reopened this Feb 19, 2026
@arntsonl
Copy link
Contributor

Tested my hardware including some new reverse polarity switches I got as well as rapid trigger testing.

Thank you for the submission @j-wut !!!

@arntsonl arntsonl merged commit 1423771 into OpenStickCommunity:main Feb 23, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants