Support binary payload in RTCDataChannel#24
Open
js-seo wants to merge 3 commits intoOpenTelecom:masterfrom
Open
Support binary payload in RTCDataChannel#24js-seo wants to merge 3 commits intoOpenTelecom:masterfrom
js-seo wants to merge 3 commits intoOpenTelecom:masterfrom
Conversation
Contributor
|
Interesting PR, I may back port this feature on https://github.com/cordova-rtc/cordova-plugin-iosrtc |
Contributor
|
@js-seo WOW! Thanks so much for contributing this! We will review asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.bufferwhich was at 157 line inRTCDataChannel.jsbefore this change was becoming{}when it gets to theWKWebViewRTC.swiftthrough the bridge. So data was not being sent as expected.datafield of the first argument(event) ofRTCDataChannel.prototype.onmessageis nowArrayBufferfollowing the native browser API, other than{ Type: 'ArrayBuffer', Data: string }