Conversation
|
Hi there @nclm Thank you so much for taking time to contribute these policies for tracking. I will be reviewing them and will leave suggestions for some changes you can make to fix it and have the GitHub Actions test pass and make it ready for merging |
Cli4d
left a comment
Cli4d
left a comment
There was a problem hiding this comment.
Hi @nclm,
I have reviewed your contribution and would like to suggest the following changes:
- Rename the terms type names to align with our terms triptych.
- Update the Service Name and Service ID (file name) to accurately reflect the actual service.
Additionally, you will notice that some terms types, such as Commercial Terms, appear more than once in your document. In such cases, we should combine the documents of similar terms types into one.
You can refer to the documentation for guidance on how to do this. If anything is unclear you can ask for clarification.
I would be happy to conduct a second review after you implement these suggested changes.
P.S. The categorization of terms types is based on my perspective; you are welcome to reclassify them as long as they fit within the categories of the terms triptych.
Thank you for your contributions!
| @@ -0,0 +1,57 @@ | |||
| { | |||
| "name": "Canva and Affinity", | |||
There was a problem hiding this comment.
According to our documentation, we would need to attribute this to only one service. The one responsible for the policies. In this case Canva. This is the Service Name. But also it usually has the same value as the Service ID which is the name of the JSON file. So we might need to change that as well to Canva
| "name": "Canva and Affinity", | |
| "name": "Canva", |
| "terms": { | ||
| "Privacy Policy": { | ||
| "fetch": "https://www.canva.com/policies/privacy-policy/", | ||
| "select": "div[class=HqfB2mG]" |
There was a problem hiding this comment.
For selectors as well, you can just use the .className notation. It keeps it simple. Now I have had a look at the terms and this seems to be a good selector pairing that we can use in this case. We try as much as possible to look for alternative selectors that are simple and not system generated. You can target a wider region then remove unnecessary sections, if there is no single simple selector that can target the desired section
You can have a look at this suggestion and if it looks good you can replicate it throughout all the other documents as they have a similar structure
| "select": "div[class=HqfB2mG]" | |
| "select": "#__next", | |
| "remove": [ | |
| "header", | |
| "footer", | |
| ".sW0ID7p" | |
| ] |
| "fetch": "https://www.canva.com/policies/acceptable-use-policy/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Affinity Terms": { |
There was a problem hiding this comment.
We usually use a Terms Tryptich to govern how we categorize policies. It makes it easier to know which policies are there and what they entail and also helps prevent having too many categorization which makes it hard to analyze and link changes.
So I will suggest we also categorize this based on the options on the tryptich as it doesn't exist in our tryptich
| "Affinity Terms": { | |
| "Commercial Terms": { |
| "fetch": "https://www.canva.com/policies/affinity-additional-terms/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "AI Product Terms": { |
There was a problem hiding this comment.
Same for this one (categorize based on the terms tryptich)
| "AI Product Terms": { | |
| "Restricted Use Policy": { |
| "fetch": "https://www.canva.com/policies/ai-product-terms/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Beta Service Terms": { |
There was a problem hiding this comment.
| "Beta Service Terms": { | |
| "Commercial Terms": { |
| "fetch": "https://www.canva.com/policies/edu-additional-terms/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Canva Subscription Agreement": { |
There was a problem hiding this comment.
| "Canva Subscription Agreement": { | |
| "Commercial Terms": { |
| "fetch": "https://www.canva.com/policies/enterprise-ssa/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Canva's Content License Agreement": { |
There was a problem hiding this comment.
| "Canva's Content License Agreement": { | |
| "Content Monetisation Policy": { |
| "fetch": "https://www.canva.com/policies/content-license-agreement/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Contributor Agreement": { |
There was a problem hiding this comment.
| "Contributor Agreement": { | |
| "Marketplace Sellers Conditions": { |
| "fetch": "https://www.canva.com/policies/contributor-agreement/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Cookies Policy": { |
There was a problem hiding this comment.
| "Cookies Policy": { | |
| "Trackers Policy": { |
| "fetch": "https://www.canva.com/policies/cookies-policy/", | ||
| "select": "div[class=HqfB2mG]" | ||
| }, | ||
| "Data Processing Addendum": { |
There was a problem hiding this comment.
| "Data Processing Addendum": { | |
| "Data Processor Agreement": { |
2 participants
Hello, this is my first time trying to add declarations on OTA.
Adding all the terms for Canva and Affinity that can be found on https://www.canva.com/trust/legal/ under “For customers and users”. Several of those date from yesterday where they greatly changed the Affinity offer.
I couldn’t find a better selector than
div[class=HqfB2mG]because their site is generated by Next and the HTML is a mess.Note that they have their own archives of policies at this address: https://www.canva.com/policies/policy-archives/ – not sure if they can somehow be integrated to OTA’s history. Older Affinity-only terms might be archived somewhere from Serif.com.