deprecation: add runtime warnings to deprecated exec/which methods#121
Merged
bastelfreak merged 1 commit intoJul 13, 2026
Merged
Conversation
bastelfreak
added
the
backwards-incompatible
Contributor
|
@silug can you please rebase and do |
Add explicit runtime deprecation warnings (via Facter.warnonce) to methods that are slated for removal in a future major version: - Facter::Core::Execution.exec: warn callers to use .execute instead - Facter::Util::Resolution.exec: replaced bare public :exec with an explicit method that warns and delegates to Facter::Core::Execution - Facter::Util::Resolution.which: same treatment as .exec above Specs updated to assert the deprecation warning is emitted; new specs added for the Resolution class-level deprecated methods. References OpenVoxProject#88, OpenVoxProject#89 Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
silug
force-pushed
the
deprecation-warnings-exec-which
branch
from
5c356cd to
bb9e71b
Compare
bastelfreak
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Add explicit runtime deprecation warnings (via Facter.warnonce) to methods that are slated for removal in a future major version:
Specs updated to assert the deprecation warning is emitted; new specs added for the Resolution class-level deprecated methods.
References #88, #89
Checklist
I have:
Signed-off-byannotation to each of my commits