test: fix e2e deploy tests — load hardhat-ethers, use funded TRE key - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing test-harness gaps kept the e2e deploy tests from running outside CI (the suite self-skips when no TRE is reachable, so CI never caught them):
hre.etherswas undefined —@nomicfoundation/hardhat-ethersandhardhat-chai-matchersare peer deps the plugin decorates but weren't installed or loaded. Added them todevDependenciesand required them before the plugin in the fixture config.tronbox/treimage doesn't fund. Switched the default to the TRE-funded dev key.No source or behavior changes. Local
npm testagainst a running TRE now passes end to end.