Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
543944b to
59d8b10
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
59d8b10 to
907947f
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
8e0ba93 to
c1fcb49
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
128fc40 to
57adc35
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
7c50070 to
ba39fc2
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
ba39fc2 to
dd91187
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
dd91187 to
5ff0bbf
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
d6ac3d5 to
43b07d9
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
43b07d9 to
f9739aa
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
f9739aa to
4cb6f14
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
4cb6f14 to
c5adf76
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
c5adf76 to
6e29aa7
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
6e29aa7 to
d7c0815
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
3 times, most recently
from
f9bfdef to
71612f9
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
4 times, most recently
from
d7ec87c to
3a070da
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
4 times, most recently
from
3707fe9 to
5a330af
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
728ef4e to
4f8205c
Compare
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
b4fda1d to
973e0fc
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
8808dc7 to
8e6808c
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
746c6fe to
1d9fab8
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
a7a7411 to
cdaeded
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
3 times, most recently
from
85eb918 to
6b9c571
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
1797b93 to
cfa30e8
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
cfa30e8 to
03f6035
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
2 times, most recently
from
f5d4062 to
87a8c72
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
3 times, most recently
from
19e06b2 to
c064426
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
3 times, most recently
from
5364b5c to
02f5815
Compare
WalkthroughThe pull request upgrades ESLint and related TypeScript linting devDependencies to newer major versions: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
10-11: The--ignore-pathCLI flag has been removed in ESLint 9.The lint script on line 11 uses
--ignore-path .gitignore, but "'ignorePath' has been removed. 'rulePaths' has been removed. Please define your rules using plugins."In ESLint 9 with flat config, "you can use the ignores property in a config object with no other properties. The ignores property accepts an array of glob patterns."
🔧 Suggested fix: Update lint script and migrate ignore patterns to flat config
Remove the
--ignore-pathflag from the script:- "lint:path": "eslint --ignore-path .gitignore --max-warnings 0", + "lint:path": "eslint --max-warnings 0",Then in your new
eslint.config.js, add the ignore patterns:export default [ { ignores: [ 'node_modules/**', 'dist/**', // ... other patterns from .gitignore that should be ignored by ESLint ] }, // ... rest of config ];
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 19-24: The current ESLint 9 upgrade will break the existing
.eslintrc.js + lint:path script that uses --ignore-path; either migrate to flat
config by running the migration tool to produce eslint.config.js (npx
`@eslint/migrate-config` .eslintrc.js), update the new eslint.config.js to call
includeIgnoreFile() from `@eslint/compat` to load .gitignore patterns, and remove
--ignore-path from the lint:path npm script, or temporarily toggle legacy
behavior by setting ESLINT_USE_FLAT_CONFIG=false in the lint:path script
environment so the existing .eslintrc.js continues to work; also ensure Node.js
engine in package.json meets ESLint 9 minimum (≥18.18.0).
🧹 Nitpick comments (1)
package.json (1)
17-31: Consider adding dependencies required for ESLint 9 flat config migration."The migrator will prompt you to install additional packages...
@eslint/js: ESLint team start to make a core rewrite the ESLint, all the rules, documentations will move to the new package...@eslint/compat: This package allow you to wrap existing previous ESLint rules, plugins and configurations."Depending on your configuration, you may need to add:
@eslint/js- for ESLint's built-in recommended rulesglobals- for defining global variables in flat config@eslint/compator@eslint/eslintrc- if plugins don't fully support flat config yet"devDependencies": { "@openzeppelin/docs-utils": "^0.1.0", + "@eslint/js": "^9.0.0", "@typescript-eslint/eslint-plugin": "^8.0.0", "@typescript-eslint/parser": "^8.0.0", "eslint": "^9.0.0", "eslint-config-prettier": "^10.0.0", "eslint-plugin-prettier": "^5.0.0", "eslint-plugin-unicorn": "^62.0.0", "ethers": "^6.8.1", + "globals": "^16.0.0",
package.json
Outdated
| "@typescript-eslint/eslint-plugin": "^8.0.0", | ||
| "@typescript-eslint/parser": "^8.0.0", | ||
| "eslint": "^9.0.0", | ||
| "eslint-config-prettier": "^10.0.0", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "eslint-plugin-unicorn": "^51.0.0", | ||
| "eslint-plugin-unicorn": "^62.0.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find existing ESLint configuration files
echo "=== Existing ESLint config files ==="
find . -maxdepth 2 -name '.eslintrc*' -o -name 'eslint.config.*' 2>/dev/null | head -20
# Check for .eslintignore
echo -e "\n=== .eslintignore files ==="
find . -maxdepth 2 -name '.eslintignore' 2>/dev/null
# Check Node.js version requirements
echo -e "\n=== Node.js version constraints ==="
jq '.engines' package.json 2>/dev/null || echo "No engines field in package.json"
# Check the lint script in package.json
echo -e "\n=== Lint script in package.json ==="
jq '.scripts.lint' package.jsonRepository: OpenZeppelin/openzeppelin-upgrades
Length of output: 256
🏁 Script executed:
#!/bin/bash
# Let's check the full scripts section and lines around 11 in package.json
echo "=== Full package.json scripts section ==="
jq '.scripts' package.json
echo -e "\n=== Lines 1-30 of package.json for context ==="
head -n 30 package.json | cat -nRepository: OpenZeppelin/openzeppelin-upgrades
Length of output: 1949
🏁 Script executed:
#!/bin/bash
# Check the .eslintrc.js configuration
echo "=== Contents of .eslintrc.js ==="
cat .eslintrc.js
# Verify ESLint v9 breaking change documentation
echo -e "\n=== Checking for flat config usage ==="
if grep -q "eslint.config" package.json; then
echo "Uses flat config"
else
echo "Does not use flat config"
fiRepository: OpenZeppelin/openzeppelin-upgrades
Length of output: 1302
🏁 Script executed:
#!/bin/bash
# Double-check for eslint.config.js file
echo "=== Searching for eslint.config files ==="
find . -maxdepth 2 -name 'eslint.config.*' 2>/dev/null | head -20
# Verify the --ignore-path flag issue by checking ESLint 9 documentation
echo -e "\n=== ESLint version and config format check ==="
echo "ESLint version in package.json:"
jq '.devDependencies.eslint' package.json
# Check if .gitignore exists (referenced in lint:path)
echo -e "\n=== Checking .gitignore ==="
ls -la .gitignore 2>/dev/null | head -1Repository: OpenZeppelin/openzeppelin-upgrades
Length of output: 296
🌐 Web query:
ESLint 9.0.0 --ignore-path CLI flag removed breaking change
💡 Result:
In ESLint v9.0.0, when using the new flat config (eslint.config.js), the CLI no longer supports several legacy flags, including --ignore-path. This is because flat config does not read .eslintignore files, so there’s no “ignore file path” concept to point ESLint at via CLI. (eslint.org)
What to do instead
- Move ignore patterns into
eslint.config.js(preferred in v9 flat config), e.g. use flat-config ignores or import ignore files. - If you previously did
--ignore-path .gitignore, ESLint recommends importing it viaincludeIgnoreFile()from@eslint/compatineslint.config.js. (eslint.org)
(If you’re seeing advice that this flag is “removed from ESLint entirely,” note it’s specifically unsupported with flat config in v9; ESLint’s v9 migration docs and config migration guide call this out under flat-config CLI flag changes.) (eslint.org)
Citations:
- 1: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 2: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 3: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
🌐 Web query:
ESLint 9 legacy .eslintrc.js support --ignore-path flag compatibility
💡 Result:
In ESLint 9, flat config (eslint.config.*) is the default, and --ignore-path is not supported in flat-config mode. ESLint also doesn’t read .eslintignore in flat-config mode. (eslint.org)
What works (and what doesn’t)
-
Default ESLint 9 (flat config):
--ignore-pathdoes not work. (eslint.org)- Use instead:
ignores: [...]ineslint.config.*, orincludeIgnoreFile()from@eslint/compatto import.gitignore/ignore files. (eslint.org)
-
Legacy
.eslintrc.*mode (ESLint 9):- Legacy config is still available if you set
ESLINT_USE_FLAT_CONFIG=false. (eslint.org) - In that legacy mode,
--ignore-pathis part of the eslintrc-era CLI behavior (it’s specifically called out as removed only for flat config), so it’s the mode you must be in if you need--ignore-path. (eslint.org)
- Legacy config is still available if you set
Common “gotcha” (integrations/tools)
If you’re using an integration that passes options like ignorePath programmatically (not via the CLI), ESLint 9’s newer API path may reject it; such tools typically need updating to ESLint 9 / flat config, or to explicitly use the legacy API (LegacyESLint). (github.com)
Citations:
- 1: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 2: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 3: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 4: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/?utm_source=openai
- 5: https://eslint.org/docs/latest/use/configure/migration-guide?utm_source=openai
- 6: Incompatible with eslint@9 fi3ework/vite-plugin-checker#320
Migrate ESLint configuration to flat config format or explicitly enable legacy mode—the current setup will fail with ESLint 9.
ESLint 9 defaults to flat config mode, which no longer reads .eslintrc.js files or supports the --ignore-path CLI flag. The current lint:path script uses --ignore-path .gitignore, which will fail with ESLint 9's default flat config.
To resolve this, choose one of:
-
Migrate to flat config (recommended): Create
eslint.config.jsusing the ESLint migration tool:npx `@eslint/migrate-config` .eslintrc.jsThen update the
lint:pathscript to remove--ignore-pathand instead useincludeIgnoreFile()from@eslint/compatin the flat config to load.gitignorepatterns. -
Enable legacy mode temporarily: Set the environment variable
ESLINT_USE_FLAT_CONFIG=falseto keep using the.eslintrc.jsformat, though this is not recommended long-term as ESLint is phasing out legacy config support.
Also consider specifying Node.js version constraints (ESLint 9 requires Node.js ≥ v18.18.0).
🤖 Prompt for AI Agents
In `@package.json` around lines 19 - 24, The current ESLint 9 upgrade will break
the existing .eslintrc.js + lint:path script that uses --ignore-path; either
migrate to flat config by running the migration tool to produce eslint.config.js
(npx `@eslint/migrate-config` .eslintrc.js), update the new eslint.config.js to
call includeIgnoreFile() from `@eslint/compat` to load .gitignore patterns, and
remove --ignore-path from the lint:path npm script, or temporarily toggle legacy
behavior by setting ESLINT_USE_FLAT_CONFIG=false in the lint:path script
environment so the existing .eslintrc.js continues to work; also ensure Node.js
engine in package.json meets ESLint 9 minimum (≥18.18.0).
5fab8d9 to
cff250e
Compare
renovate
bot
force-pushed
the
renovate/major-linters
branch
from
cff250e to
c40203b
Compare
This PR contains the following updates:
^7.0.0→^8.0.0^7.0.0→^8.0.0^8.0.0→^10.0.0^9.0.0→^10.0.0^51.0.0→^64.0.0Release Notes
typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v8.58.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.58.0Compare Source
🚀 Features
🩹 Fixes
no-unnecessary-type-arguments(#12163)❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.2Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.1Compare Source
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.57.0Compare Source
🚀 Features
🩹 Fixes
TypeOrValueSpecifierto prefer-promise-reject-errors (#12094)cookedwill benull(#11355)❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.56.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.56.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.55.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
See GitHub Releases for more information.
You can read about our versioning strategy and releases on our website.
v8.54.0Compare Source
🚀 Features
🩹 Fixes
def.name(#11982)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.53.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.53.0Compare Source
🚀 Features
🩹 Fixes
errortyped" with more helpful description (#11704)extendsandimplementsin interface declaration (#11935)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.52.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.51.0Compare Source
🚀 Features
🩹 Fixes
no-useless-default-assignment(#11845)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.50.1Compare Source
🩹 Fixes
this(#11813)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.50.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.49.0Compare Source
🚀 Features
Intl.Segmenterinstead ofgraphemer(#11804)🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.48.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.48.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.47.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.4Compare Source
🩹 Fixes
projectServiceandprojectare set (#11333)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.3Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.2Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.1Compare Source
🩹 Fixes
.finallynot to report when a promise returning function is provided as an argument (#11667)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.0Compare Source
🚀 Features
🩹 Fixes
export imports (#11603)this: voidand binding (#11634)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.45.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.43.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.42.0Compare Source
🩹 Fixes
You can read about our versioning strategy and releases on our website.
v8.41.0Compare Source
🩹 Fixes
You can read about our versioning strategy and releases on our website.
v8.40.0Compare Source
🚀 Features
EnumMember(#11232)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.39.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.39.0Compare Source
🚀 Features
🩹 Fixes
unsafeObjectPatternmessage (#11403)checkoption for most RHS of a chain (#11272)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.38.0Compare Source
🩹 Fixes
isolatedDeclarationsif enabled inconstructoroption (#11351)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.37.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.36.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.35.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.35.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.34.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.34.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.33.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.33.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.32.1Compare Source
🩹 Fixes
TSMappedTypewith no type annotation (#11180)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.32.0Compare Source
🚀 Features
allowRethrowing(#11075)🩹 Fixes
thisfrom optional parameter overload check (#11005)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.31.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.31.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.30.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
[
v8.30.0](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.