Change synthetic context injection to assistant role#147
Closed
Change synthetic context injection to assistant role#147
Conversation
… message Instead of creating a synthetic assistant message (which breaks thinking models that require the final assistant message to start with a thinking block), inject the prunable tools list as a text part appended to the most recent assistant message. This preserves the message structure during tool use loops and works across all providers/models.
|
Did this yield better results for you? |
Collaborator
Author
|
Yes the performance is definitely better, models are trained to address user messages so getting them to ignore the message is very hacky, but its harder to work with for 2 reasons:
I haven't looked into this too much yet, if anyone wants to help this would be big! |
Collaborator
Author
|
figured this out finally, merged to dev in #187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary