Implement memory regions iterators#104
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
qbojj
requested changes
May 3, 2026
Co-authored-by: Copilot <copilot@github.com>
Kamilosok
requested changes
May 5, 2026
Kamilosok
left a comment
Kamilosok
left a comment
Collaborator
There was a problem hiding this comment.
The dt logic looks fine, didn't find anything wrong with memory stuff at a glance, though requesting a review from @frogrammer9 on this is a good idea. Noticed a few consistency issues.
And moved hal to be a part of kernel instead of a library
Collaborator
|
could you look at the clang-tidy warnings? (please ignore the nonnull ones though) |
qbojj
previously approved these changes
May 26, 2026
frogrammer9
requested changes
May 29, 2026
frogrammer9
left a comment
frogrammer9
left a comment
Contributor
There was a problem hiding this comment.
Lacking docs page. Please create a doxygroup in file docs/doxygen/groups.dox and add all your file to it and create a page in API directory referencing this group. You can check if it renders correctly by running ./scripts/build_docs.sh and opening /docs/built/html/index.html with your browser of choice.
frogrammer9
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.