Avoids unnecessary allocations#732
Conversation
sarahelsaig
left a comment
There was a problem hiding this comment.
In LoginInfoJsonConverter the instance is registered in code (see here).
The created Instance variables here are not actually used.
As a lib or nuget, we can create it for the extensible for other custom module to extend by registration and DI |
That's not useful. You should never have to use these converters directly, because are tied to the converted class using an attribute: If for some reason you still need an instance of the converter, you can create a static instance in your own code. Adding these static properties here would only be confusing for everyone else. |
Fix #731