This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Open
Conversation
… generate temporary credentials from the instance metadata, before using those credentials to deploy the shop to Amazon S3
… generate temporary credentials from the instance metadata, before using those credentials to deploy the shop to Amazon S3
…o look for the shop admin's AWS credentials before creating an Amazon S3 client
…yed on an AWS EC2 instance.
phyninja
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1011.
If
DShop will now programatically request the admin's AWS credentials and attempt an S3 deployment. This takes the source code one step closer to complying with AWS Marketplace's security policy, which forbids apps from requesting a[n AWS Marketplace] buyer's credentials.