-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add SKILL.MD agent onboarding and MarkItDown document processor #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2459201
d6e0a71
143112d
1d5d7a6
b342e53
38c7442
586b762
9408de8
f17ccc2
52d106c
2ba7db9
67afc26
f0ac40a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1596,7 +1596,9 @@ export class DKGAgent { | |
| includeWorkspace?: boolean; | ||
| operationCtx?: OperationContext; | ||
| view?: GetView; | ||
| agentAddress?: string; | ||
| verifiedGraph?: string; | ||
| assertionName?: string; | ||
| subGraphName?: string; | ||
| }, | ||
| ) { | ||
|
|
@@ -1615,8 +1617,9 @@ export class DKGAgent { | |
| graphSuffix: opts.graphSuffix, | ||
| includeSharedMemory: opts.includeSharedMemory, | ||
| view: opts.view, | ||
| agentAddress: opts.view === 'working-memory' ? this.peerId : undefined, | ||
| agentAddress: opts.agentAddress ?? (opts.view === 'working-memory' ? this.peerId : undefined), | ||
| verifiedGraph: opts.verifiedGraph, | ||
| assertionName: opts.assertionName, | ||
| subGraphName: opts.subGraphName, | ||
| }); | ||
| this.log.info(ctx, `Query returned ${result.bindings?.length ?? 0} bindings`); | ||
|
|
@@ -2067,8 +2070,8 @@ export class DKGAgent { | |
| try { await this.store.dropGraph(uri); } catch { /* graph may not exist */ } | ||
| } | ||
|
|
||
| // Drop assertion/draft graphs under the sub-graph prefix | ||
| const sgPrefix = `did:dkg:context-graph:${contextGraphId}/${subGraphName}/draft/`; | ||
| // Drop assertion graphs under the sub-graph prefix | ||
| const sgPrefix = `did:dkg:context-graph:${contextGraphId}/${subGraphName}/assertion/`; | ||
| const allGraphs = await this.store.listGraphs(); | ||
| for (const g of allGraphs) { | ||
| if (g.startsWith(sgPrefix)) { | ||
|
|
@@ -3641,25 +3644,25 @@ export class DKGAgent { | |
| } | ||
| } | ||
|
|
||
| // ── Working Memory Draft Operations (spec §6) ──────────────────────── | ||
| // ── Working Memory Assertion Operations (spec §6) ─────────────────── | ||
|
|
||
| get draft() { | ||
| get assertion() { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: Renaming the public SDK surface from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: this removes the public There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: Renaming the public
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Already addressed — There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: Replacing the public
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The deprecated
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intentional rename for V10.0. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: Renaming the public SDK surface from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: This removes the public
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 52d106c — added There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: Renaming the public working-memory API from
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not applicable — V10 unreleased, no external consumers. |
||
| const agent = this; | ||
| const agentAddress = this.peerId; | ||
| return { | ||
| async create(contextGraphId: string, draftName: string, opts?: { subGraphName?: string }): Promise<string> { | ||
| return agent.publisher.draftCreate(contextGraphId, draftName, agentAddress, opts?.subGraphName); | ||
| async create(contextGraphId: string, name: string, opts?: { subGraphName?: string }): Promise<string> { | ||
| return agent.publisher.assertionCreate(contextGraphId, name, agentAddress, opts?.subGraphName); | ||
| }, | ||
|
|
||
| /** | ||
| * Write triples to a WM draft. Accepts: | ||
| * Write triples to a WM assertion. Accepts: | ||
| * - `Quad[]` — standard quad array (same as publish/share) | ||
| * - `JsonLdContent` — JSON-LD document, auto-converted to quads | ||
| * - `Array<{ subject, predicate, object }>` — legacy triple array (deprecated) | ||
| * - `Array<{ subject, predicate, object }>` — simple triple array | ||
| */ | ||
| async write( | ||
| contextGraphId: string, | ||
| draftName: string, | ||
| name: string, | ||
| input: import('@origintrail-official/dkg-storage').Quad[] | JsonLdContent | Array<{ subject: string; predicate: string; object: string }>, | ||
| opts?: { subGraphName?: string }, | ||
| ): Promise<void> { | ||
|
|
@@ -3673,17 +3676,17 @@ export class DKGAgent { | |
| quads = (input as Array<{ subject: string; predicate: string; object: string }>) | ||
| .map(t => ({ subject: t.subject, predicate: t.predicate, object: t.object, graph: '' })); | ||
| } | ||
| return agent.publisher.draftWrite(contextGraphId, draftName, agentAddress, quads, opts?.subGraphName); | ||
| return agent.publisher.assertionWrite(contextGraphId, name, agentAddress, quads, opts?.subGraphName); | ||
| }, | ||
|
|
||
| async query(contextGraphId: string, draftName: string, opts?: { subGraphName?: string }): Promise<import('@origintrail-official/dkg-storage').Quad[]> { | ||
| return agent.publisher.draftQuery(contextGraphId, draftName, agentAddress, opts?.subGraphName); | ||
| async query(contextGraphId: string, name: string, opts?: { subGraphName?: string }): Promise<import('@origintrail-official/dkg-storage').Quad[]> { | ||
| return agent.publisher.assertionQuery(contextGraphId, name, agentAddress, opts?.subGraphName); | ||
| }, | ||
| async promote(contextGraphId: string, draftName: string, opts?: { entities?: string[] | 'all'; subGraphName?: string }): Promise<{ promotedCount: number }> { | ||
| return agent.publisher.draftPromote(contextGraphId, draftName, agentAddress, opts); | ||
| async promote(contextGraphId: string, name: string, opts?: { entities?: string[] | 'all'; subGraphName?: string }): Promise<{ promotedCount: number }> { | ||
| return agent.publisher.assertionPromote(contextGraphId, name, agentAddress, opts); | ||
| }, | ||
| async discard(contextGraphId: string, draftName: string, opts?: { subGraphName?: string }): Promise<void> { | ||
| return agent.publisher.draftDiscard(contextGraphId, draftName, agentAddress, opts?.subGraphName); | ||
| async discard(contextGraphId: string, name: string, opts?: { subGraphName?: string }): Promise<void> { | ||
| return agent.publisher.assertionDiscard(contextGraphId, name, agentAddress, opts?.subGraphName); | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ | |
| "files": [ | ||
| "dist", | ||
| "network", | ||
| "skills", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Issue: The new
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acknowledged — the |
||
| "README.md", | ||
| "LICENSE" | ||
| ], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Bug:
draftNamedisappeared from the publicDKGAgent.query()options even though the lower query layer still accepts it as a deprecated alias. That turns this rename into a compile-time break for existing TypeScript callers. AdddraftName?: stringhere and forward it alongsideassertionNamefor this release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable — V10 is unreleased, no TypeScript callers use
draftName. Removed intentionally in 67afc26.