Skip to content

feat(alerts): add opt-in immediate alert popups#578

Merged
Orinks merged 5 commits intodevfrom
feat/alert-popup-optin
Apr 8, 2026
Merged

feat(alerts): add opt-in immediate alert popups#578
Orinks merged 5 commits intodevfrom
feat/alert-popup-optin

Conversation

@Orinks
Copy link
Copy Markdown
Owner

@Orinks Orinks commented Apr 8, 2026

Summary

  • add an opt-in setting for immediate alert detail popups while AccessiWeather is already running
  • reuse AlertManager eligibility/filtering so single eligible alerts open the existing detail dialog and multi-alert batches open one combined dialog
  • keep the main window hidden/minimized when showing these popups and cover the new behavior with targeted tests

Verification

  • pytest -q tests/test_models.py tests/test_settings_dialog_tray_text.py tests/test_alert_notification_system.py tests/test_app_immediate_alert_popups.py tests/test_app_notification_activation.py tests/test_system_tray.py tests/gui/test_main_window_minimize.py
  • ruff check src/accessiweather/app.py src/accessiweather/alert_notification_system.py src/accessiweather/app_initialization.py src/accessiweather/models/config.py src/accessiweather/ui/dialogs/alerts_summary_dialog.py src/accessiweather/ui/dialogs/init.py src/accessiweather/ui/dialogs/settings_tabs/notifications.py tests/test_alert_notification_system.py tests/test_app_immediate_alert_popups.py tests/test_models.py tests/test_settings_dialog_tray_text.py

Notes

  • local pyright/Claude/Gemini CLI review was not available in this environment

@Orinks Orinks merged commit 6067da7 into dev Apr 8, 2026
3 checks passed
@Orinks Orinks deleted the feat/alert-popup-optin branch April 8, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant