Skip to content

Validate agent connector ids on update #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgnoreMeBut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate agent connector ids on update #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/features/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1733,7 +1733,10 @@ async function _applyAgentUpdates(
if (v === null) {
delete (data as { enabled_connectors?: unknown }).enabled_connectors;
} else if (Array.isArray(v)) {
const ids = v.filter((s): s is string => typeof s === 'string' && s.length > 0);
const ids = v
.filter((s): s is string => typeof s === 'string')
.map((s) => s.trim())
.filter((s) => s.length > 0 && safeId(s));
(data as { enabled_connectors?: string[] }).enabled_connectors = ids;
}
}
Expand Down
11 changes: 11 additions & 0 deletions test/main/features/agents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,6 +1264,17 @@ describe('agents › updateCustomAgent', () => {
expect(updated?.skill_list).toEqual(['ok-1', 'ok_2']);
});

it('filters invalid enabled connector ids on write', async () => {
writeCustomAgent('abc', { name: 'N' });
const a = await loadAgents();
const updated = await a.updateCustomAgent('abc', {
enabled_connectors: [' github ', '../bad', 42 as any, 'notion'],
});
expect(updated?.enabled_connectors).toEqual(['github', 'notion']);
const raw = JSON.parse(fs.readFileSync(path.join(customAgentsDir(), 'abc', 'agent.json'), 'utf8'));
expect(raw.enabled_connectors).toEqual(['github', 'notion']);
});

it('writes skill_list = [] as explicit zero (kept, not dropped)', async () => {
writeSkillOnDisk('a');
writeCustomAgent('abc', { name: 'N', skill_list: ['a'] });
Expand Down