Conversation
|
This breaks with docker. |
There was a problem hiding this comment.
Pull request overview
Updates the devcontainer configuration to preserve host group memberships when running the container with podman/docker, which is typically needed for correct device/file permission behavior inside the devcontainer.
Changes:
- Add a
--group-add keep-groupsentry to.devcontainer/devcontainer.jsonrunArgs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--group-add keep-groups", |
There was a problem hiding this comment.
runArgs entries are passed as individual CLI arguments; including a space inside the string will be sent as a single token (--group-add keep-groups) and may be rejected by podman/docker as an unknown flag. Split this into two array elements (flag and value) or use an equals form (--group-add=keep-groups) so the runtime parses it correctly.
| "--group-add keep-groups", | |
| "--group-add=keep-groups", |
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--group-add keep-groups", |
There was a problem hiding this comment.
The new runArgs line has inconsistent indentation (leading spaces before tabs) compared to the rest of this file, which primarily uses tabs. Please align indentation to match the surrounding formatting to avoid noisy diffs later.
| "--group-add keep-groups", | |
| "--group-add keep-groups", |
also see containers/podman#25607