Skip to content

Fixing Inlines displaying as Editable#112

Open
gascarcella wants to merge 3 commits into
OskarPersson:read-only-change-viewfrom
gascarcella:read-only-change-view
Open

Fixing Inlines displaying as Editable#112
gascarcella wants to merge 3 commits into
OskarPersson:read-only-change-viewfrom
gascarcella:read-only-change-view

Conversation

@gascarcella

Copy link
Copy Markdown

Fixed Inlines displaying as Editable on Read Only view.

We still need to get rid of the add buttons

image

@OskarPersson i hope you can take a look. I'll have some time to work on this tomorrow

@OskarPersson

Copy link
Copy Markdown
Owner

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

@gascarcella

Copy link
Copy Markdown
Author

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

Thanks and sorry for closing the last one! 1st time contributing to open source

@OskarPersson

Copy link
Copy Markdown
Owner

@gascarcella I updated your branch. I have managed to get rid of the add button. The delete checkbox is still there in the upper-right, but you can't do anything with it since the save button is not there any more. Tell me if this works for you or not :)

@OskarPersson

Copy link
Copy Markdown
Owner

@gascarcella Have you had any time to look into my updates?

@gascarcella

Copy link
Copy Markdown
Author

Hey @OskarPersson .
I'm really sorry, im busy on another project until tomorrow.
I'll have time Saturday and Sunday, and will post you an update asap.

We keep in touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants