fix(dashboard-api): ignore commented lines in read_env_file_value in performance_oracle.py - #2510
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
…performance_oracle.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/extensions/services/dashboard-api/performance_oracle.py,read_env_file_value()reads key-value assignments from.envfiles by iterating over raw lines. If a commented line like# CTX_SIZE=32768existed before an active variable definition,line.startswith(f"{key}=")previously matched the commented string.Fix
Update
read_env_file_value()inperformance_oracle.pyto strip whitespace and skip empty or comment lines starting with#.Verification
Ran
pytest ods/extensions/services/dashboard-api/tests/test_performance_oracle.py(50/50 passed).git diff --checkpassed cleanly.