fix(dashboard-api): ignore whitespace and comments in _find_env_file_value in config.py - #2513
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
…value in config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/extensions/services/dashboard-api/config.py,_find_env_file_value()parses.envfile lines to extract configuration values. Lines with leading whitespace or commented entries like# ODS_MODE=localwere previously evaluated without skipping comments first.Fix
Update
_find_env_file_value()inconfig.pyto strip line whitespace and ignore blank lines or lines starting with#.Verification
Ran
pytest ods/extensions/services/dashboard-api/tests/test_config.py(53/53 passed).git diff --checkpassed cleanly.