fix(ods-cli): split env diff on first '=' and strip CR/quotes - #2645
Open
patil2001 wants to merge 1 commit into
Open
fix(ods-cli): split env diff on first '=' and strip CR/quotes#2645patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
cmd_preset env comparison used 'IFS== read' which split on every '=', truncating JWT/base64 secrets and query-string URLs at the first '='. Both sides truncated identically, so real differences after the first '=' were reported as 'no difference'. Now split on the first '=' only and strip trailing CR and matching surrounding quotes, matching lib/safe-env.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2297.
cmd_presetenv comparison usedIFS== readwhich split on every=, truncating JWT/base64 secrets and query-string URLs at the first=. Both sides truncated identically, so real differences after the first=were reported as "no difference".Change
Split on the first
=only and strip trailing CR and matching surrounding quotes, matchinglib/safe-env.sh.Test plan
.envwhose values contain embedded=; diff now reports genuine changes.