fix(host-agent): verify opencode provider npm, model name, and output limit - #2646
Open
patil2001 wants to merge 1 commit into
Open
fix(host-agent): verify opencode provider npm, model name, and output limit#2646patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
… limit _opencode_config_matches only compared model/small_model, baseURL, apiKey, and limit.context, so a wrong provider package, served name, or a clamped output limit went undetected before apply was declared stable. It now also verifies the provider npm is @ai-sdk/openai-compatible, the model name matches the routed display name when provided, and limit.output is at least min(32768, context_length).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_opencode_config_matchesonly compared model/small_model, baseURL, apiKey, and limit.context, so a wrong provider package, served name, or a clamped output limit went undetected before apply was declared stable.Change
It now also verifies the provider npm is
@ai-sdk/openai-compatible, the model name matches the routed display name when provided, and limit.output is at leastmin(32768, context_length).Test plan