fix(opencode): skip writing blank model id into Windows config - #2647
Open
patil2001 wants to merge 1 commit into
Open
fix(opencode): skip writing blank model id into Windows config#2647patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
When the Lemonade model id resolved to empty, the Windows config write set model and small_model to an empty value and masked the served model. The write is now skipped on null or whitespace, mirroring the existing empty value skip behavior in the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Lemonade model id resolved to empty, the Windows config write set model and small_model to an empty value and masked the served model.
Change
The write is now skipped on null or whitespace, mirroring the existing empty value skip behavior in the function.
Test plan